Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add project fields validator #334

Open
wants to merge 41 commits into
base: master
Choose a base branch
from
Open

ci: add project fields validator #334

wants to merge 41 commits into from
+679 −0

Conversation

minikin
Copy link
Collaborator

@minikin minikin commented Oct 18, 2024 •
edited
Loading

Description

  • auto assign PR creator as assignee
  • verifies that all project fields are filled out and fail if any are left unfilled.

resolves #333

@minikin minikin self-assigned this Oct 18, 2024
@minikin minikin added do not merge yet PR is not ready to be merged yet do not review yet Do not review yet labels Oct 18, 2024
@minikin minikin assigned minikin and unassigned minikin Oct 22, 2024
@minikin minikin assigned minikin and unassigned minikin Oct 22, 2024
Mr-Leshiy
Mr-Leshiy previously approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minikin minikin added review me PR is ready for review and removed do not review yet Do not review yet labels Oct 27, 2024
@minikin
Copy link
Collaborator Author

minikin commented Oct 27, 2024 •
edited
Loading

@stevenj, can you please review? Let me know if we should create a better code structure for Python.
PS: The validate-project-fields job is failing because the GitHub token used in CI doesn't have sufficient permissions to access the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenj stevenj stevenj left review comments

@Mr-Leshiy Mr-Leshiy Mr-Leshiy left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@minikin minikin

Labels
do not merge yet PR is not ready to be merged yet review me PR is ready for review
Projects
Catalyst
Status: 👀 In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Make github action/s which can pre populate and validate Project fields in PRs and Issues
4 participants
@minikin @stevenj @Mr-Leshiy @jmgilman