Update snowflake dependency and add more tests #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnephin
force-pushed
the
dnephin/update-and-fix-snowflake-ids
branch
2 times, most recently
from
08c9ec6
to
25b17d8
Compare
7 tasks
To pickup some bug fixes from dnephin/snowid@7511dd2 Which fix problems with uid.Parse
jmorganca
approved these changes
Apr 27, 2022
uid/snowflake_test.go
Outdated
| id: "JPwcyDCgEuqJPwcyDCgEuq", | ||
| expectedErr: `invalid base58 id "JPwcyDCgEuqJPwcyDCgEuq"`, | ||
| }, | ||
| // does not result in an error, but probably should |
There was a problem hiding this comment.
Should we keep this commented out?
There was a problem hiding this comment.
Ya, we can't fix this one yet until bwmarrin/snowflake#45 is merged, or we use a fork. I can add a link.
dnephin
changed the title
ssoroka
approved these changes
Apr 27, 2022
dnephin
force-pushed
the
dnephin/update-and-fix-snowflake-ids
branch
from
25b17d8
to
1a99f24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While working on a change to our API, I ran into some unexpected behaviour. I traced it to this bug fix, which we don't have yet because there has not been a release of this project for 3 years.
This PR adds some more tests, and updates the dependency.