Update project strcuture publish #29
Conversation
thisAAY
commented
Oct 11, 2024
thisAAY
commented
- Updated the publishing setup
- Updated Gradle from 4.9 to 8.9
- Updated JDK from 7 to 17
- Updated kotlin from 1.3.72 to 2.0.20
- Updated Deps
- Migrated to Version Catalog
- Refactored to multi-module setup to include the library and samples, Instead of having two different projects
|
| publish.properties | ||
| *.gpg |
| developers { | ||
| developers { | ||
| developer { | ||
| id.set("antunflas") | ||
| name.set("Antun Flaš") | ||
| email.set("[email protected]") | ||
| } | ||
| } | ||
| developer { | ||
| id = 'thisAAY' | ||
| name = 'Ahmed Ali' | ||
| email = '[email protected]' | ||
| } | ||
| } |
There was a problem hiding this comment.
It's not really a blocker or big thing. But we should replace personal info with company's info.
organization {
name = 'Infinum Inc.'
url = 'https://infinum.com'
}
developers {
developer {
id = 'Infinum'
name = 'Infinum Inc.'
url = 'https://infinum.com'
}
}
There was a problem hiding this comment.
Should we do this for all libs? because i think this is the same setup for JsonApiX too
There was a problem hiding this comment.
Yes, but it is not big priority, you can fix it on JsonApiX when you will do some work there
| version = "$versions.retromock" | ||
|
|
||
| artifact sourceJar | ||
| artifact javadocJar | ||
|
|
||
| pom { | ||
| name.set("Retromock") |
There was a problem hiding this comment.
Can't we just apply project level publish file?
There was a problem hiding this comment.
Just for feature reasons, in case we have different modules that can be published, so I just went with our current setup
There was a problem hiding this comment.
This file should not be pushed to remote
There was a problem hiding this comment.
Same here, just remove it from the project, but history can stay as is 🤷
|
|
||
| username: findProperty("sonatypeUsername")?.toString() | ||
| ?: properties["sonatype.user"] | ||
| ?: System.getenv("SONATYPE_USERNAME"), |
There was a problem hiding this comment.
Btw, I have these env variables defined and I avoid using publish.properties, because it works on all projects automatically, and don't have to think about updating gitignore
There was a problem hiding this comment.
Yes, I would suggest removing this line from every library and the template if it exists there, so we don't encourage using a file that can be easily pushed to gitignore
There was a problem hiding this comment.
cc @KCeh, let's plan to remove publish.properties from the library projects then.
There was a problem hiding this comment.
👌
I will recheck all libs, in library template there is no such file
There was a problem hiding this comment.
I'm sorry, I didn't mean to check if there is a file. I suggested removing the usage of the properties file in this file.
There was a problem hiding this comment.
This can also be in gitignore, right?
There was a problem hiding this comment.
I will update gitinore again, and force some updates in the history of this branch
There was a problem hiding this comment.
This shouldn't be harmful, so we can leave it in history.
| @@ -30,7 +30,6 @@ afterEvaluate { | |||
| version = "$versions.retromock" | |||
|
|
|||
| artifact sourceJar | |||
| artifact javadocJar | |||
There was a problem hiding this comment.
Is the doc automatically added?
