Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only warn about argument sizes on Nvidia GPUs #713

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matthiasdiener
Copy link
Contributor

No description provided.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain the context a bit more? Were there spurious warnings that were bothersome?

dev_limit = _get_max_parameter_size(dev)
if dev_limit != 4352:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I like this check, it seems too broad. I expect that AMD and Intel GPUs would have some limit as well, but these changes would avoid warnings in those cases, even if they're applicable. I would be more willing to limit this to GPU devices, which is testable via flags in the device info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants