Full circle: Nextflow #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e really outputs. Also, add `valueRequired` property to output FormalParameters.
Also, slightly change on root dataset query to get its `isBasedOn`, as WorkflowHub is now automatically setting it.
…`, calling methods from `wfexs_backend.utils.rocrate` toolbox.
…language has a clear separation between inputs and outputs. Also, much better "expected" and "materialized" output parameter handling. Last, but not the least important, now each run has its own separate intermediate directory, to completely isolate runs.
Now, each autofilled input injects an autofilled expected output labelled as not synthetic, in order to distinguish real (i.e. parameterized) from synthetic outputs (i.e. based on glob patterns or output directory exploding).
WfExS RO-Terms are used for the labelling.
The scenario being tested is one using a Nextflow workflow, where output parameters are not explicitly declared by nextflow itself. So, several custom terms have to be used to properly describe the execution. Also, some corner cases have been caught.
… were not including it in either `contentUrl` or `identifier`.
… could come from `identifier` instead of `contentUrl`. Basic Nextflow workflows are now properly imported!!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge includes many fixes around RO-Crate generation and consumption, as well as processing hints.
contentUrloridentifierproperties.contentUrl, and added querying aboutidentifieras an alternate forcontentUrl.identifieras an alternate provider of file or dataset input PIDs.