-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First stage RO-Crate import #90
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new `import` command, to import a Workflow-Run profiles compliant RO-Crate into a new staged working directory, in order to run it.
…g args.workflowConfigFilename for imports
Also, detection code has been moved from WfExSBackend to WF class, so it is better reused.
…t is the version of WfExS-backend the one defining the accepted values
…ontainer factories and workflow engines. * Also, added a couple of new command line commands to list them. * Additionally, created wfexs_backend.utils.rocrate.ROCrateToolbox , to move there the methods to generate a WfExS definition from an input RO-Crate metadata. * Other code was also refactored. * Now the list of executions and containers from a WRROC is walked.
…e module to `wfexs_backend.utils.rocrate` one
…here to avoid more complicated dependencies
As this list of containers does not have an explicit representation in the workflow staging definition, explicitly return it.
Next commits should implement rebuilding the input parameters properly.
…py pre-commit hook
…the identification phase.
…ve to be "stringified"
…g a prospective provenance scenario (i.e. all is gathered, but nothing was run)
Also, several type definitions have been moved from common to their most natural place.
Also, a few type definitions have been moved from common to their most natural places.
…wfexs_backend.fetchers`
…actRepoFetcher` Also, refactored previous implementations in wfexs_backend.fetchers.git and wfexs_backend.fetchers.swh under GitFetcher and SoftwareHeritageFetcher. This work is needed to allow future modular repository providers.
…iginal one is used instead of a possibly consolidated one.
It is currently working with WRROCs from CWL workflows. (Nextflow WWROC generation has to be fixed)
Added support for RO-Crate import (only metadata), and input parameters replacement. Still pending to fix RO-Crate generation for Nextflow, so the imported RO-Crates can be consumed without issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it is possible to properly import WRROCs produced by WfExS which represent CWL executions.
Technically, properly generated WRROCs from Nextflow executions should also be importable, but RO-Crate generation must be fixed first to properly generate them.