feat(server/client): service quick reload #131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1715173329
reviewed
Aug 1, 2024
| @@ -340,6 +341,13 @@ return view.extend({ | |||
| } | |||
| so.default = 'nil'; | |||
| so.rmempty = false; | |||
|
|
|||
| so = ss.option(form.Button, '_reload_client', _('Quick Reload')); | |||
There was a problem hiding this comment.
I don't see any sense of this change.
There was a problem hiding this comment.
emmm... I can probably list a few points.
- Faster than
Default outbound: proxy --> nil --> SAVE --> proxy --> APPLY - This is faster when hp stops due to itself or other reasons
There was a problem hiding this comment.
- you have to edit uci configuration to stop the service if use
reloadmethod. - procd should automatically restart the service
There was a problem hiding this comment.
- But stop_service does not check the value of
outbound_node, it just terminates the service completely. - procd sometimes fails to respawn, and I have set the watchdog to stop the hp service when the proxy node is offline for a long time
There was a problem hiding this comment.
- that will not stop the service anyway, it's just restart. manually restart can be done via
system->startup. - then you should check logs, why it fails. procd will only stop respawn if the service crashed 5 times in one hour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow manual quick reload of hp service