Skip to content

Commit

Permalink
Add tolerance for train_loss check in test_fsdp.py
Browse files Browse the repository at this point in the history
  • Loading branch information
regisss committed Oct 4, 2024
1 parent 8ed336a commit e625fce
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tests/test_fsdp_examples.py
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ def _test_fsdp(
if model_name == "bert-base-uncased":
assert results["eval_f1"] >= ACCURACY_PERF_FACTOR * baseline_acc
else:
assert results["train_loss"] <= baseline_acc
assert results["train_loss"] <= (2 - ACCURACY_PERF_FACTOR) * baseline_acc


@pytest.mark.parametrize(
Expand Down

0 comments on commit e625fce

Please sign in to comment.