14525 Would like kmdb module for vmm #105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmustacc
reviewed
Jan 13, 2024
| @@ -188,7 +188,7 @@ is opaque to the walker: it must not modify or dereference this value, nor | |||
| can it assume it is a pointer to valid memory.</para> | |||
| <para>The starting address for the walk is stored in <replaceable>walk_addr</replaceable>. | |||
| This is either NULL if <function>mdb_walk</function> was called, or the address | |||
| parameter specified to <function>mdb_pwalk</function>. If the <command>::walk</command> built-in | |||
| parameter specified to <function>mdb_pwalk</function> or <function>mdb_fpwalk</function>. If the <command>::walk</command> built-in | |||
There was a problem hiding this comment.
Sorry for the long delay in getting to this; however, I don't think this integrated with the name mdb_fpwalk did it? It looks like this was meant to be mdb_fpwalk_dcmd? Is that correct here and below?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of change 14525 a new walker was introduced that uses
a flag parameter to expose the context in which the dcmd was invoked.