Drop 'typing_extensions', use modern annotations #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikalnytskyi
force-pushed
the
chore/typing
branch
5 times, most recently
from
48970cc
to
d946bf0
Compare
Since introduction of `from __future__ import annotations` in the project sources, the annotations evaluations aren't happening at runtime, which means we can start using modern type annotation techniques, such as | operand instead of Union. It also means we can completely rely on the `typing` module and drop `typing_extensions` because all imports are now under TYPE_CHECKING, and their usage in signatures are not evaluated at runtime.
ikalnytskyi
force-pushed
the
chore/typing
branch
from
d946bf0
to
c8dd464
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since introduction of
from __future__ import annotationsin the project sources, the annotations evaluations aren't happening at runtime, which means we can start using modern type annotation techniques, such as | operand instead of Union.It also means we can completely rely on the
typingmodule and droptyping_extensionsbecause all imports are now under TYPE_CHECKING, and their usage in signatures are not evaluated at runtime.