feat: support for metadata-directive
#12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igungor
reviewed
Sep 25, 2023
igungor
approved these changes
Sep 25, 2023
|
Can you merge and tag it please, I don't have the permissions for it :D |
Tagged as |
ilkinulas
pushed a commit
to peak/s5cmd
that referenced
this pull request
Jul 5, 2024
This PR allows to specify whether to keep the existing metadata of the object or replace with a new one when copying from `s3` to `s3`. Tests will pass after the [PR](igungor/gofakes3#12) that will be merged to `gofakes3`. Resolves #666 Resolves #711
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature allows to specify whether to keep the existing metadata of the object or replace with a new one when copying from
s3tos3. Will be used in the tests of the PR.