Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added templates API #90

Merged
merged 12 commits into from
Dec 3, 2023
Merged

Added templates API #90

merged 12 commits into from
Dec 3, 2023

Conversation

@emersonu
Copy link
Contributor

This feature is very useful and I wanted to understand if I can help in any way.

What is still missing to finish it?

@ignacio-chiazzo
Copy link
Owner Author

@emersonu thanks for looking at it. I commented what is missing. I won't have time this week to tackle it but if you want to continue I can review it. Otherwise, I will work on it late next week.

@ignacio-chiazzo ignacio-chiazzo force-pushed the implement-templates branch 5 times, most recently from d8f9c4e to a38ac4d Compare September 15, 2023 01:22
@ignacio-chiazzo ignacio-chiazzo mentioned this pull request Sep 25, 2023
@ignacio-chiazzo ignacio-chiazzo force-pushed the implement-templates branch 2 times, most recently from 1db08f2 to 4219efd Compare December 3, 2023 23:29
@ignacio-chiazzo ignacio-chiazzo changed the title [WIP] Add templates API Added templates API Dec 3, 2023
@ignacio-chiazzo ignacio-chiazzo marked this pull request as ready for review December 3, 2023 23:34
@ignacio-chiazzo ignacio-chiazzo merged commit e74453d into main Dec 3, 2023
4 checks passed
@ignacio-chiazzo
Copy link
Owner Author

Thanks, @emersonu, for contributing! I merged the feature.

@emersonu
Copy link
Contributor

emersonu commented Dec 4, 2023

Pleased to help @ignacio-chiazzo!

@ignacio-chiazzo ignacio-chiazzo deleted the implement-templates branch December 6, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants