Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

leetcode problem palindrome.cpp #59

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

leetcode problem palindrome.cpp #59

wants to merge 2 commits into from

Conversation

Monika3002
Copy link

No description provided.

ignacio-chiazzo
ignacio-chiazzo reviewed Oct 7, 2022
View reviewed changes
Copy link
Owner

@ignacio-chiazzo ignacio-chiazzo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! thanks for the solution, could you please follow the format (See guide and PR example).

I love c++, but this repo uses Javascript as the main language. Could you translate it to javascript?

Thank you!

Monika3002
Monika3002 commented Oct 7, 2022
View reviewed changes
Copy link
Author

@Monika3002 Monika3002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I give some test cases here. Thanks

@ignacio-chiazzo
Copy link
Owner

Thanks @Monika3002!

Could you follow the following format:

  1. use Javascript.
  2. Create a file for the problem'solution.
  3. Create a file for unit tests.

See the guide and the latest PR as an example #64

My DMs are open if it's not clear (https://twitter.com/IgnacioChiazzo).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ignacio-chiazzo ignacio-chiazzo ignacio-chiazzo left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Monika3002 @ignacio-chiazzo