Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RecoverEthereum accept only 65 len sig #59

Merged
merged 5 commits into from
Oct 30, 2024
Merged

Conversation

volodymyr-basiuk
Copy link
Contributor

No description provided.

@volodymyr-basiuk volodymyr-basiuk marked this pull request as ready for review October 11, 2024 07:49
if len(sig) == 64 && alg == "ES256K-R" {
sig = append(sig, []byte{1}...)
}
if len(sig) == 64 && alg == "ES256K" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that we can recover public key from signature with ES256K alg?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can recover ETH address for ES256K/ES256K-R
unit tests added

Copy link

gitguardian bot commented Oct 30, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
14031549 Triggered Generic High Entropy Secret 7b42ed1 packers/jws_test.go View secret
14031549 Triggered Generic High Entropy Secret 08ed8bd packers/jws_test.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@volodymyr-basiuk volodymyr-basiuk merged commit a8ae97b into main Oct 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants