filtering settings for targets during Synthetic history interpolation #2394
+38
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
#2389
What are the significant changes in functionality due to this change request?
The Problem
During interpolation of a SyntheticHistory ROM, learned features from a characterizing TSA algorithm are interpolated between missing data years. The interpolated values are then written to the final ROM for the missing macroSteps.
When setting the values, each TSA characterizing algorithm (whether
global
orlocal
/per segment) reads in a dictionary of interpolated params and loops through all target signals to set new values. However, if we have an XML where we have two nodes of the same algorithm, the target list is mismatched from the trained params and the interpolated params. An example is shown below with a modified/tests/framework/ROM/TimeSeries/SyntheticHistory/varma_interpolated.xml
test that has two added<fourier>
algorithms:The Solution
The problem is solved by properly filtering the trained settings based on the correct node before setting the ROM features.
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>
to True.raven/tests/framework/user_guide
andraven/docs/workshop
) have been changed, the associated documentation must be reviewed and assured the text matches the example.