Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update SR2ML submodule ID #1213

Merged
merged 1 commit into from
Apr 15, 2020
Merged

Conversation

wangcj05
Copy link
Collaborator

@wangcj05 wangcj05 commented Apr 15, 2020


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

See #1114

What are the significant changes in functionality due to this change request?

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@wangcj05 wangcj05 requested a review from alfoa April 15, 2020 15:16
@moosebuild
Copy link

Job Test OpenSUSE Leap 15 on 9ebcaae : invalidated by @wangcj05

DIFF in tests/framework/PostProcessors/LimitSurface/limitSurface/LimitSurfacePositiveNegative_dump.csv: Different values in y0 for 8.72891337589 and 8.63956426031 Different values in y0 for 7.74607310452 and 7.65672398894 Different values in y0 for 3.81471201903 and 3.90406113461 Different values in y0 for 2.83187174766 and 2.92122086324 Different values in y0 for 1.84903147629 and 1.93838059187 Different values in y0 for 8.63956426031 and 8.55021514473 Different values in y0 for 7.65672398894 and 7.56737487336 Different values in y0 for 3.72536290345 and 3.81471201903 Different values in y0 for 2.74252263208 and 2.83187174766 Different values in y0 for 1.75968236071 and 1.84903147629 (298/705) Diff ( 6.87sec)tests/framework/PostProcessors/LimitSurface/testLimitSurfacePostProcessor

@wangcj05
Copy link
Collaborator Author

@alfoa I think I saw the test "tests/framework/PostProcessors/LimitSurface/testLimitSurfacePostProcessor" randomly failed several times in different machines
Also see issue #1189

@wangcj05
Copy link
Collaborator Author

@alfoa @PaulTalbot-INL This PR is ready for your review. This PR is used to update the SR2ML Plugin submodule ID.

Copy link
Collaborator

@PaulTalbot-INL PaulTalbot-INL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple submodule change; no complaints.

@PaulTalbot-INL
Copy link
Collaborator

Checked, and the allowed-to-fail submodule tests are passing as well as the regular tests.

Checklists pass, merging.

@PaulTalbot-INL PaulTalbot-INL merged commit 3b0c351 into devel Apr 15, 2020
@alfoa alfoa deleted the wangc/update_SR2ML_submodule_ID branch April 16, 2020 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants