Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow auxiliary variables for FE IKs #28978

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

GiudGiud
Copy link
Contributor

Refs #28977

the issue also exists for FVIks but they have logic there for multi-system that prevent any error / seg fault.
The fact that we hit this problem probably means we are missing multi-system logic for regular IKs

@GiudGiud GiudGiud self-assigned this Oct 31, 2024
@GiudGiud GiudGiud marked this pull request as ready for review October 31, 2024 16:09
@moosebuild
Copy link
Contributor

Job Documentation, step Docs: sync website on ced9d7e wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

Job Coverage, step Generate coverage on ced9d7e wanted to post the following:

Framework coverage

b8db75 #28978 ced9d7
Total Total +/- New
Rate 85.08% 85.08% +0.00% 100.00%
Hits 106569 106571 +2 2
Misses 18694 18694 - 0

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

Copy link
Member

@lindsayad lindsayad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if I'm ready to say we should ban this. I'd want to see if whether we gracefully early returned whether the user that prompted this has a good/valid formulation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants