Linear FV Fluid Energy equation #28952
Conversation
| @@ -21,11 +21,14 @@ LinearFVSource::validParams() | |||
| "Represents the matrix and right hand side contributions of a " | |||
| "solution-independent source term in a partial differential equation."); | |||
| params.addParam<MooseFunctorName>("source_density", 1.0, "The source density."); | |||
| params.addParam<Real>("scaling_factor", 1.0, "Coefficient to multiply by the body force term"); | |||
There was a problem hiding this comment.
| params.addParam<Real>("scaling_factor", 1.0, "Coefficient to multiply by the body force term"); | |
| params.addParam<Real>("scaling_factor", 1.0, "Coefficient to multiply the body force term with"); |
| @@ -33,4 +33,7 @@ class LinearFVSource : public LinearFVElementalKernel | |||
| protected: | |||
| /// The functor for the source density | |||
| const Moose::Functor<Real> & _source_density; | |||
|
|
|||
| /// Scale factor | |||
| const Real & _scale; | |||
There was a problem hiding this comment.
| const Real & _scale; | |
| const Real _scale; |
for efficiency. If you use a reference, every time the kernel acts it needs to go retrieve the value from the parameters' memory
the only reason to make it a reference would be to make it controllable
| * Kernel that adds the component of the pressure gradient in the momentum | ||
| * equations to the right hand side. | ||
| */ | ||
| class LinearFVMomentumBoussinesq : public LinearFVElementalKernel |
There was a problem hiding this comment.
ok let's wait for the design discussion before including this?
|
|
||
| protected: | ||
| /// Fluid Temperature | ||
| MooseLinearVariableFV<Real> & getTemperatureVariable(const std::string & vname); |
There was a problem hiding this comment.
const ?
same for the attribute
| const RealVectorValue _gravity; | ||
| /// The thermal expansion coefficient | ||
| const Moose::Functor<Real> & _alpha; | ||
| /// Reference temperature at which the value of _rho was measured |
There was a problem hiding this comment.
| /// Reference temperature at which the value of _rho was measured | |
| /// Reference temperature at which the reference value of the density was measured |
rho_0 does not show up in your implementation so it's not as clear what you mean
| params.suppressParameter<unsigned int>("energy_l_max_its"); | ||
| // params.suppressParameter<Real>("energy_l_tol"); | ||
| // params.suppressParameter<Real>("energy_l_abs_tol"); | ||
| // params.suppressParameter<unsigned int>("energy_l_max_its"); |
| InputParameters params = LinearFVFluxKernel::validParams(); | ||
| params.addClassDescription("Represents the matrix and right hand side contributions of an " | ||
| "advection term for the energy e.g. h=cp*T. A user may still " | ||
| "override what quantity is advected, but the default is cp*T."); |
There was a problem hiding this comment.
| "override what quantity is advected, but the default is cp*T."); | |
| "override what quantity is advected, but the default is the specific enthalpy"); |
what specific enthalpy means is defined elsewhere than the kernel
| registerMooseObject("MooseApp", LinearFVEnergyAdvection); | ||
|
|
||
| InputParameters | ||
| LinearFVEnergyAdvection::validParams() |
There was a problem hiding this comment.
we should consider with @grmnptr whether we want a kernel for energy when it's the same as scalar and we could just call it scalarAdvection
| params.addParam<MooseFunctorName>("alpha_name", | ||
| NS::alpha_boussinesq, | ||
| "The name of the thermal expansion coefficient" | ||
| "this is of the form rho = rho*(1-alpha (T-T_ref))"); |
There was a problem hiding this comment.
| "this is of the form rho = rho*(1-alpha (T-T_ref))"); | |
| "The density is then computed as rho*(1-alpha | |
| *(T-T_ref))"); |
|
Job Precheck, step Clang format on 988efef wanted to post the following: Your code requires style changes. A patch was auto generated and copied here
Alternatively, with your repository up to date and in the top level of your repository:
|
Closes #28951