Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hit formatting of "electrothermal with phase field" input files #132

Merged

Conversation

apb13
Copy link
Contributor

@apb13 apb13 commented Jun 26, 2024

We will rely on the syntax checking in CIVET to test these files for continued functionality, particularly the two input files located in this file path: ~/projects/malamute/examples/sps/multiapp/electrothermal_with_phase_field/twoway_lots_of_particles_prototype.

I was not able to compare the simulation outputs for these two input files located in "twoway_lots_of_particles_prototype".

For the remaining four input files, I performed a comparison between two csv files, one that was the original and another that received hit formatting, to ensure that the results were the same. Also ensured that comments were formatted correctly in the input file.

Refs #128

@sapitts
Copy link
Collaborator

sapitts commented Jun 27, 2024

@apb13 there are six input files in this commit, but your message only describes two of the six input files. Please edit your PR (using the instructions @cticenhour gave you on your second PR) to describe the work done with the remaining four input files

@apb13 apb13 force-pushed the hit-electrothermal_with_phase_field-128 branch from 5a572d7 to 995d992 Compare June 27, 2024 17:22
@moosebuild
Copy link

Job Documentation on 995d992 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link

Job Coverage on 995d992 wanted to post the following:

Coverage

Coverage did not change

Full coverage report

This comment will be updated on new commits.

@sapitts
Copy link
Collaborator

sapitts commented Jul 2, 2024

@apb13 did you run the input files engineering_scale_electrothermal_oneway_controls.i, engineering_scale_electrothermal_twoway_prototype.i, and engineering_scale_electrothermal_twoways_lots_prototype.i for at least the first two timesteps to make sure that the removal of the extra [ThermalContact] lines did not adversely affect the simulation?

@apb13
Copy link
Contributor Author

apb13 commented Jul 2, 2024

@sapitts Yes, I ran these three input files for at least two timesteps. Removing the extra [ThermalContact] lines did not have a negative impact on the simulation.

@sapitts sapitts merged commit 137e7c9 into idaholab:devel Jul 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants