-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated syntax in ConcreteThermalMoisture #322
base: devel
Are you sure you want to change the base?
Conversation
Job Precheck on b43b388 wanted to post the following: Your code requires style changes. A patch was auto generated and copied here
Alternatively, with your repository up to date and in the top level of your repository:
|
b43b388
to
17a30b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only had a question but I approve
_cement_mass = isParamValid("cement_mass") ? getParam<Real>("cement_mass") : 354.0; | ||
_water_to_cement = | ||
isParamValid("water_to_cement_ratio") ? getParam<Real>("water_to_cement_ratio") : 0.43; | ||
_cement_type = isParamValid("cement_type") ? getParam<MooseEnum>("cement_type") : 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you still need to set or check all of these defaults for the moisture_diffusivity_models?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. The way the new syntax (which we've been using for a while) works, those are all effectively required parameters for whatever model you're using. We should at least capture these recommended values, maybe just as comments in the code, so we don't lose them.
closes #318