Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove remaining model for mineral dissolution/precipitation #274

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Remove remaining model for mineral dissolution/precipitation #274

merged 1 commit into from
Oct 28, 2021

Conversation

bwspenc
Copy link
Collaborator

@bwspenc bwspenc commented Oct 27, 2021

ref #171

This should have been removed in commit 727d12b
on May 5, 2021, but was missed.

@bwspenc
Remove remaining model for mineral dissolution/precipitation ref idah…
333dd8b 
…olab#171

This should have been removed in commit 727d12b
on May 5, 2021, but was missed.
@moosebuild
Copy link

Job Test on 333dd8b wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link

Job Coverage on 333dd8b wanted to post the following:

Coverage

Coverage did not change

Full coverage report

This comment will be updated on new commits.

SudiptaBiswas
SudiptaBiswas approved these changes Oct 28, 2021
View reviewed changes
Copy link
Collaborator

@SudiptaBiswas SudiptaBiswas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@SudiptaBiswas SudiptaBiswas merged commit 29dbc58 into idaholab:devel Oct 28, 2021
@bwspenc bwspenc deleted the rm_mineral branch October 28, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SudiptaBiswas SudiptaBiswas SudiptaBiswas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bwspenc @moosebuild @SudiptaBiswas