Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add val 2c to TMAP8 for Test Cell Experiment #197

Merged
merged 21 commits into from
Oct 30, 2024
Merged

Add val 2c to TMAP8 for Test Cell Experiment #197

merged 21 commits into from
Oct 30, 2024

Conversation

simopier
Copy link
Collaborator

(Ref. #12)
(Close. #98)

Add Val-2c and improve figure quality in V&V cases.

@simopier simopier added the V&V Relevant to V&V label Oct 23, 2024
@simopier simopier self-assigned this Oct 23, 2024
@moosebuild
Copy link

moosebuild commented Oct 23, 2024 •
edited
Loading

Job Documentation, step Sync to remote on 384e477 wanted to post the following:

View the site here

This comment will be updated on new commits.

@simopier simopier force-pushed the TMAP8_val_2c branch 2 times, most recently from 8abddfb to 588b7da Compare October 24, 2024 04:16
@simopier simopier mentioned this pull request Oct 24, 2024
Merged
@simopier
Copy link
Collaborator Author

I created the following issue for the challenge I ran into for p>2 tests: #200

@moosebuild
Copy link

moosebuild commented Oct 25, 2024 •
edited
Loading

Job Coverage, step Generate coverage on 384e477 wanted to post the following:

Coverage

aee97e #197 384e47
Total Total +/- New
Rate 91.41% 91.69% +0.28% -
Hits 330 331 +1 0
Misses 31 30 -1 0

Diff coverage report

Full coverage report

This comment will be updated on new commits.

@simopier simopier mentioned this pull request Oct 25, 2024
Open
cticenhour
cticenhour requested changes Oct 29, 2024
View reviewed changes
doc/content/bib/tmap8.bib Outdated Show resolved Hide resolved
doc/content/verification_and_validation/val-2c.md Show resolved Hide resolved
doc/content/verification_and_validation/val-2c.md Outdated Show resolved Hide resolved
doc/content/verification_and_validation/val-2c.md Outdated Show resolved Hide resolved
doc/content/verification_and_validation/val-2c.md Outdated Show resolved Hide resolved
test/tests/val-2c/val-2c_delay.i Outdated Show resolved Hide resolved
test/tests/val-2c/val-2c_delay.i Outdated Show resolved Hide resolved
test/tests/val-2c/val-2c_immediate_injection.i Outdated Show resolved Hide resolved
test/tests/val-2c/val-2c_immediate_injection.i Outdated Show resolved Hide resolved
test/tests/val-2c/val-2c_base.i Outdated Show resolved Hide resolved
cticenhour
cticenhour approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@cticenhour cticenhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this, but due to merging Lin's last PR, this one now has a merge conflict that needs to be addressed.

@cticenhour cticenhour merged commit 16e837e into devel Oct 30, 2024
8 checks passed
@cticenhour cticenhour deleted the TMAP8_val_2c branch October 30, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cticenhour cticenhour cticenhour approved these changes

@chaibhave chaibhave Awaiting requested review from chaibhave

@lin-yang-ly lin-yang-ly Awaiting requested review from lin-yang-ly

Assignees

@simopier simopier

Labels
V&V Relevant to V&V
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simopier @moosebuild @cticenhour