Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation case val2a #189

Merged
merged 28 commits into from
Oct 30, 2024
Merged

Add validation case val2a #189

merged 28 commits into from
Oct 30, 2024

Commits on Oct 25, 2024

  1. Draft version 

    (Ref. idaholab#188)
    @lin-yang-ly
    lin-yang-ly committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    8755bcc View commit details
    Browse the repository at this point in the history

  2. Update documentation

    @lin-yang-ly
    lin-yang-ly committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    a8e92db View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Pierre-Clement Simon <[email protected]>
    @lin-yang-ly @simopier
    lin-yang-ly and simopier committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    c7425d4 View commit details
    Browse the repository at this point in the history

  4. Simplify input files

    @lin-yang-ly
    lin-yang-ly committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    bf35b71 View commit details
    Browse the repository at this point in the history

  5. Update figures in documentation

    @lin-yang-ly
    lin-yang-ly committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    4489c32 View commit details
    Browse the repository at this point in the history

  6. Fix typos

    @lin-yang-ly
    lin-yang-ly committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    e196afd View commit details
    Browse the repository at this point in the history

  7. Update model

    @lin-yang-ly
    lin-yang-ly committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    6f31341 View commit details
    Browse the repository at this point in the history

  8. update_model

    @lin-yang-ly
    lin-yang-ly committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    74a12cc View commit details
    Browse the repository at this point in the history

  9. Update documentation

    @lin-yang-ly
    lin-yang-ly committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    86b6c3e View commit details
    Browse the repository at this point in the history

  10. Remove the data from TMAP7

    @lin-yang-ly
    lin-yang-ly committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    4d862ca View commit details
    Browse the repository at this point in the history

  11. fix typo

    @lin-yang-ly
    lin-yang-ly committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    96369ce View commit details
    Browse the repository at this point in the history

  12. Apply suggestions from code review 

    Co-authored-by: Pierre-Clement Simon <[email protected]>
    @lin-yang-ly @simopier
    lin-yang-ly and simopier committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    27fefd3 View commit details
    Browse the repository at this point in the history

  13. Update documentation

    @lin-yang-ly
    lin-yang-ly committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    ee540cd View commit details
    Browse the repository at this point in the history

  14. Update documentation

    @lin-yang-ly
    lin-yang-ly committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    5938078 View commit details
    Browse the repository at this point in the history

  15. Update test cases

    @lin-yang-ly
    lin-yang-ly committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    7f1be1c View commit details
    Browse the repository at this point in the history

  16. attempt to fix issue on checks 

    use constant time step

update tolerance

update tolerance 2

high tolerance with low time step

loose tolerance

lower tolerance

mum to nm for better converge

update output parameters

alter time step

update time step

update time step

maybe very high tolerance

A test for better performance

roll back

Apply suggestions from code review

Co-authored-by: Pierre-Clement Simon <[email protected]>
    @lin-yang-ly @simopier
    lin-yang-ly and simopier committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    5fa5925 View commit details
    Browse the repository at this point in the history

  17. update mesh and add exodus

    @lin-yang-ly
    lin-yang-ly committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    165bc2b View commit details
    Browse the repository at this point in the history

  18. change nm to mum

    @lin-yang-ly
    lin-yang-ly committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    ab0dbf7 View commit details
    Browse the repository at this point in the history

  19. update interval with time_step_interval

    @lin-yang-ly
    lin-yang-ly committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    f0f2174 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Pierre-Clement Simon <[email protected]>
    @lin-yang-ly @simopier
    lin-yang-ly and simopier authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    7ee8e31 View commit details
    Browse the repository at this point in the history

  2. plot figure from python script

    @lin-yang-ly
    lin-yang-ly committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    967ffe4 View commit details
    Browse the repository at this point in the history

  3. update gold files with latest input

    @lin-yang-ly
    lin-yang-ly committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    6c043ea View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Pierre-Clement Simon <[email protected]>
    @lin-yang-ly @simopier
    lin-yang-ly and simopier authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    94ecc89 View commit details
    Browse the repository at this point in the history

  5. add factor explaination

    @lin-yang-ly
    lin-yang-ly committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    fa1ad2b View commit details
    Browse the repository at this point in the history

  6. update limited gold files

    @lin-yang-ly
    lin-yang-ly committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    f61dc23 View commit details
    Browse the repository at this point in the history

  7. improve convergence and clean up: 

    - use AD to improve convergence
- tighten tolerances
- increase max time step to reduce computational time
- remove heavy tests since the test now runs in less than 3 seconds
- update documentation
- regold
    @simopier
    simopier committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    fe118d5 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Casey Icenhour <[email protected]>
    @lin-yang-ly @cticenhour
    lin-yang-ly and cticenhour authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    4cd5dad View commit details
    Browse the repository at this point in the history

  2. update typo

    @lin-yang-ly
    lin-yang-ly committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    4755cf1 View commit details
    Browse the repository at this point in the history