Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switched to pydata theme. #565

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Switched to pydata theme. #565

merged 4 commits into from
Oct 8, 2024

Conversation

MicahGale
Copy link
Collaborator

@MicahGale MicahGale commented Oct 8, 2024 •
edited
Loading

Description

It just looks nicer. Added version to header.

Fixes #564

Checklist

  • I have performed a self-review of my own code

@MicahGale MicahGale added documentation Improvements or additions to documentation feature request An issue that improves the user interface. labels Oct 8, 2024
@MicahGale MicahGale self-assigned this Oct 8, 2024
@MicahGale MicahGale marked this pull request as ready for review October 8, 2024 12:57
tjlaboss
tjlaboss approved these changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@tjlaboss tjlaboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think RTD theme looks better :(

@MicahGale
Copy link
Collaborator Author

https://pydata-sphinx-theme.readthedocs.io/en/latest/user_guide/theme-elements.html The extra features I think makes it worth it.

@MicahGale MicahGale merged commit 27a4e97 into develop Oct 8, 2024
20 checks passed
@MicahGale MicahGale deleted the pydata_theme branch October 8, 2024 18:15
@MicahGale MicahGale mentioned this pull request Oct 9, 2024
Merged
@MicahGale
Copy link
Collaborator Author

MicahGale commented Oct 11, 2024 •
edited
Loading

No change in memory usage (duh), but went from 27.6 seconds to 26.7 seconds for this improvement. This is a 3% reduction for the "big model". Though this is a low cost O(N^2) operation, and the saving should scale accordingly.

Wrong PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjlaboss tjlaboss tjlaboss approved these changes

Assignees

@MicahGale MicahGale

Labels
documentation Improvements or additions to documentation feature request An issue that improves the user interface.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Checkout the pydata theme
2 participants
@MicahGale @tjlaboss