Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing bug when attempting to edit a cell geometry #562

Merged
merged 7 commits into from
Oct 7, 2024
Merged

Fixing bug when attempting to edit a cell geometry #562

merged 7 commits into from
Oct 7, 2024

Conversation

MicahGale
Copy link
Collaborator

@MicahGale MicahGale commented Oct 1, 2024 •
edited
Loading

Description

An error is raised when a cell geometry is edited without being fully initialized and linked to the corresponding surfaces. Rather than letting this happen instead an IllegalState is raised. This error is really most a @MicahGale problem, and shouldn't be typical user behavior.

Fixes #558

Checklist

  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@MicahGale MicahGale added the bugs A deviation from expected behavior that does not reach the level of being reportable as an "Error". label Oct 1, 2024
@MicahGale MicahGale self-assigned this Oct 1, 2024
@MicahGale MicahGale linked an issue Oct 1, 2024 that may be closed by this pull request
Bug when attempting to edit a cell geometry #558
Closed
@MicahGale MicahGale marked this pull request as ready for review October 2, 2024 13:56
tjlaboss
tjlaboss approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@tjlaboss tjlaboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the helpful error message.

@MicahGale MicahGale merged commit 7708b99 into develop Oct 7, 2024
15 checks passed
@MicahGale MicahGale deleted the 558-bug-when-attempting-to-edit-a-cell-geometry branch October 7, 2024 17:38
@MicahGale MicahGale mentioned this pull request Oct 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjlaboss tjlaboss tjlaboss approved these changes

Assignees

@MicahGale MicahGale

Labels
bugs A deviation from expected behavior that does not reach the level of being reportable as an "Error".
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug when attempting to edit a cell geometry
2 participants
@MicahGale @tjlaboss