feat(router): add merge function #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrey Mak <[email protected]>
ibraheemdev
requested changes
Oct 11, 2024
ibraheemdev
reviewed
Oct 11, 2024
- do not mutate child router - return list of insert errors - call visitor on each node with value Signed-off-by: Andrey Mak <[email protected]>
Signed-off-by: Andrey Mak <[email protected]>
ibraheemdev
requested changes
Oct 12, 2024
- Consume child node to take values - Add MergeError to satisfy error trait Signed-off-by: Andrey Mak <[email protected]>
- initialize queue from known-size set - push back childs to make algo true BFS - adjust test cases Signed-off-by: Andrey Mak <[email protected]>
|
Looks good now, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #57
I am sure it is not the best way to implement such functionality, but since usually routes are defined at server startup there should be no significant overhead.