update to hyper 1 #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibraheemdev
reviewed
Aug 6, 2024
examples/hyper.rs
Outdated
|
|
||
| use hyper::body::{Body as HttpBody, Bytes, Frame}; | ||
|
|
||
| pub enum Body { |
There was a problem hiding this comment.
Can we use hyper_body_util::Full<Bytes> for the body type instead? This code is a little distracting from the main router code.
There was a problem hiding this comment.
Can we use hyper_body_util::Full for the body type instead?
Yes. The easy way is just using http_body_util::Full<Bytes>, to describe empty body, using Full::default constructor.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the hyper example to use hyper 1.