Adds push_with method
#10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibraheemdev
reviewed
Sep 16, 2024
Co-authored-by: Ibraheem Ahmed <[email protected]>
ibraheemdev
requested changes
Sep 22, 2024
src/raw.rs
Outdated
| F: FnOnce(usize) -> T, | ||
| { | ||
| let index = self.next_index(); | ||
| let value = f(index - 1); |
There was a problem hiding this comment.
Hmm why the subtraction here?
| /// ``` | ||
| /// let vec = boxcar::vec![0, 1]; | ||
| /// vec.push_with(|index| index + 1); | ||
| /// assert_eq!(vec, [0, 1, 2]); |
There was a problem hiding this comment.
I think this is incorrect due to above? It was inserted into index 2, so the value of the element should be 3.
There was a problem hiding this comment.
Oh boy, i goofed that entirely.
I think I was trying to figure out what the debug output of (_, _) was, added + 1 there and then promptly forgot about it (the + 1). I later added - 1 to get the test to pass 🤦♂️ .
ugh, that's quiet embarrassing. Sorry about that. It should be fixed now.
|
Nice, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
push_with, allowing forTto be produced by a closure which is passed the index of the element.Resolves #9.