Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(callout): add callout tag #323

Open
wants to merge 3 commits into
base: canary
Choose a base branch
from
Open

style(callout): add callout tag #323

wants to merge 3 commits into from

Conversation

ghouzenyan
Copy link
Contributor

@ghouzenyan ghouzenyan commented Apr 26, 2017

What kind of change does this PR introduce? (check one with "x")

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

Description

When you read the Hexo doc, you would sometimes see a blockquote with a red or yellow border, which is called callout. Here is it.

A custom tag for the Bootstrap callout style is available for material theme.

Usage:

{% note [type:default|primary|success|info|warning|danger] [header] %}
...content...
{% endnote %}

Examples:

{% note warning %}
### H3 in Warning Callout
This is a warning callout.
{% endnote %}

{% note success <h4>H4 in Success Callout</h4> %}
This is a success callout.
{% endnote %}

{% note primary Default Header in Primary Callout %}
{% endnote %}

{% note %}
This is a default callout.
{% endnote %}

BTW, I have modified the original blockquote style to unify theme style.


Verification steps

image

This is the TOC:

image

A custom tag for the Bootstrap callout style is available for material theme.
@@ -422,6 +431,109 @@ a {
border: none;
}

.bs-callout {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add a comment just as:

 /****************/
 /* Callout Style */
 /****************/

@iblh
Copy link
Owner

iblh commented Apr 27, 2017

Good job! but our markdown style is reference Github.
The default blockquote is like this below:

H3 in Primary Callout

This is a primary callout.

@neoFelhz
Copy link
Collaborator

@viosey The NexT has this style. And we can add it to the theme docs as well.
Some times we may need it.

@ghouzenyan
Copy link
Contributor Author

@viosey Ops, I refer to the design of Twitter's. So I've changed out default blockquote style. Maybe I need to learn more about material.

Copy link
Collaborator

@cubesky cubesky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is Bootstrap style ,not Material style

Copy link
Owner

@iblh iblh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This's a nice feature, but we need to refactor it's designing to cater to Material.
Take your time.

Try to materialize callout style.
Resolve the merge conflicts.
@neoFelhz neoFelhz closed this Jun 24, 2017
@neoFelhz neoFelhz reopened this Jun 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants