Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extends the SE component with various Papyrus additions. #42

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Commits on Apr 12, 2024

  1. PapyrusPerk additions.

    SkylineR390 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    c022fa8 View commit details
    Browse the repository at this point in the history
  2. PapyrusObjectReference additions.

    SkylineR390 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    64e2a1d View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. (AddItemsBulk) - Accounts for previously unconsidered base container …

    …items.
    
    If there are pre-existing items in the base container, the toal count depends on static count + countDelta instead of delta alone. Additionally, in this case the game deletes entry data only when countDelta == 0. These changes intend to mimic this behavior.
    SkylineR390 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    d7154be View commit details
    Browse the repository at this point in the history
  2. Removes GetItemCountCached

    GetItemCountCached doesn't account for any sort of concurrency. Just two simoultaneous looped calls on different containers can result at best in a cascade of data clear/rebuilds, eliminating any advantage the function might have had. Since its benefits are marginal, due to its inherent call cost and the existence of GetItemsCount, I think it best to remove it externally rather than implement a better solution not using static data.
    SkylineR390 committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    2dcf9df View commit details
    Browse the repository at this point in the history