Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

add ven to .gitignore #17

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add ven to .gitignore #17

wants to merge 3 commits into from

Conversation

urmyfaith
Copy link

RT

@mnihalm
Copy link
Collaborator

mnihalm commented Jul 18, 2019

@sidhantgoel , can you please have a look at this. It looks good to me.

@mnihalm mnihalm requested a review from sidhantgoel July 18, 2019 06:13
@@ -30,7 +30,9 @@ def test_bad_signature_pa(self):
# Generate a badly signed PA and verify that it fails signature check
with open(self.sample_public_key) as f:
pub_key = f.read()
my_art = generate_bad_sign_artefact("Rand_DRONENUM", pub_key)
COORDS = [[77.609316, 12.934158], [77.609852, 12.934796], [77.610646, 12.934183], [77.610100, 12.933551],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are these coordinates for? can we reuse already defined ones or take them as input

Copy link
Contributor

@sidhantgoel sidhantgoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants