Allow Inject-Tags if types using them are referenced in a Provider-Function #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…than an inject-funtion cleanup cleanup
Works in the test file but somehow not when running on the whole project added testfile POC: provider binding test Done documentation removed todo changed error description to match provider errors too cleanup
domeej
force-pushed
the
provider-binding-second-attempt
branch
from
faa854f
to
417475e
Compare
tessig
requested changes
Aug 20, 2021
| ) | ||
|
|
||
| // helper analyzer which returns all function declarations | ||
| var ConfigureDeclAnalyzer = &analysis.Analyzer{ |
There was a problem hiding this comment.
Not so happy that this is listed within the checks then. But for now it ts ok i think.
There was a problem hiding this comment.
Hm probably move it to analyzers/dingo? I think it should stay somewhere below dingo though
|
|
||
| func (d *D) Configure(injector *dingo.Injector) bool { | ||
| injector.Bind(new(interface{})).ToProvider(providerFunc) | ||
| injector.BindMulti(new(interface{})).ToProvider(d.providerFuncWithSelector) |
There was a problem hiding this comment.
Let's also add a BindMap here for completeness.
There was a problem hiding this comment.
What about split declarations like
bind := injector.Bind(new(interface{}))
bind.ToProvider(providerFunc)?
There was a problem hiding this comment.
That's a good point and something we doesn't check rn. Same for the binding_implements_interface analyzer, would be something I can jump on next
domeej
added a commit
that referenced
this pull request
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.