Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/improve drive id retrieval #175

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

kremerol
Copy link

I am using hypriot flash utility to flash hypriot images, but also other other images, for which the 'FAT' partition is not always the first one: for instance, the disk image for the rock-64 arm device (https://github.com/ayufan-rock64/linux-build/releases/download/0.8.3/bionic-minimal-rock64-0.8.3-1141-arm64.img.xz) has 7 partitions, and the FAT partition is number 6.
Therefore, I have improved the way to retrieve this partition id (I search for the first MSDOS partition). I did some successful test on linux and on mac (but of course, not with every possible situation).
I will be happy to see this code in a next official hypriot/flash release.

…ould be hardcoded for Hypriot images, which also works for official Ubuntu 20.04 RPI images. However, some images like Ubuntu 18.04 of rock64 create the boot disk as '/dev/disk2s6')
…d be hardcoded for Hypriot images, but not for other images)
@StefanScherer
Copy link
Member

@kremerol Thank you for the contribution. Some tests fail on CircleCI if you could have a look.

@kremerol
Copy link
Author

kremerol commented Jun 2, 2020

@StefanScherer - done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants