setup announcement actor, add endpoint for actor #42

catdevnull · 2024-02-13T18:21:04Z

Leaving this here so it can be reviewed as I go

ref

RangerMauve

This is a good start. The AP stuff looks correct. we just need the inbox now so we can accept and track followers.

RangerMauve

We also need to implement the webfinger protocol. Specifically we need to resolve /.well-known/webfinger to a json file with the mime type application/jrd+json.

example: https://github.com/RangerMauve/staticpub.mauve.moe/blob/default/.well-known/webfinger

This is necessary to enable AP instances to resolve the actor. We should use announcements@{hostname of the server} as the account others would follow. e.g. @[email protected]

src/client/cli.ts

src/server/api/announcements.ts

src/server/api/creation.ts

src/server/api/index.ts

src/server/store/index.ts

src/scripts/add-post-to-announcements.ts

RangerMauve

Excellent progress, just some minor bits left.

src/server/api/announcements.ts

src/server/announcements.ts

this will probably be removed later

because announcements is a separate ActorStore outside the actorCache, we bypass the actorCache when trying to act on the announcements actor. this should make the generic `/:actor/inbox` endpoint work for announcements.. but not tested

Co-authored-by: Mauve Signweaver <[email protected]>

mauve said it's fine it's from Mastodon

* announce to announcements actor, not to newly created actor * only update required parts of announcements actor info

src/server/api/creation.ts

RangerMauve

Maybe a new API should be made to check if the actor is existing, then set info, then announce if it was new. Place the logic outside of announcements and outside of the http API. Like server/creation.ts?

src/server/announcements.ts

RangerMauve · 2024-03-13T17:16:35Z

src/server/announcements.ts

+    if (!existedAlready && info.announce) {
+      const activity = {
+        '@context': 'https://www.w3.org/ns/activitystreams',
+        type: 'Note',


ActivityStreams hold activities, not Notes. This should be wrapped in a Create activity with the Note being the object.

e.g. here's how we link to notes in the staticpub example: https://github.com/RangerMauve/staticpub.mauve.moe/blob/default/outbox.jsonld#L13

We may need to store the notes in a separate store and add a new /:actor/note/:id URL to resolve them.

I don't see a requirement in the spec that states that OrderedCollections must hold Activitys. Actually, I was mostly copying off of Sutty's Jekyll implementation, which has plain Updates inside the outbox:

https://sutty.nl/outbox.jsonld -> https://sutty.nl/lanzamiento-de-publicaciones-distribuidas-en-el-fediverso-a-trav%C3%A9s-de-sutty/update/1701726785.jsonld

Am I getting something wrong?

Yeah, notice how the update you linked wraps the note in an Update activity. We should do the same here, but with a Create.

OH lol i thought Update was similar to a Note. But the ID there is just a link to the post, so do we need an endpoint for the individual Note?

We might, lets see if just wrapping is enough for now though.

otherwise .announce will never announce as it will exist beforehand

the same bug fixed in 0676758 applied to the test :)

src/server/announcements.ts

src/server/api/creation.ts

…vity

RangerMauve · 2024-03-13T20:26:43Z

src/server/announcements.ts

+      object: {
+        '@context': 'https://www.w3.org/ns/activitystreams',
+        type: 'Note',
+        id: `${this.outboxUrl}/${nanoid()}/note`,


I think we can change this to be #note then the json-ld magic will resolve it? I'll test like this first.

I know nothing about json-ld 🤷 but sounds good to me

src/server/announcements.ts

catdevnull · 2024-03-14T17:10:32Z

src/server/announcements.ts

+type APActorNonStandard = APActor & {
+  publicKey: {
+    id: string
+    owner: string
+    publicKeyPem: string
+  }
+}
+


this should probably be moved elsewhere but i'm not sure where. maybe src/schemas.ts? either way it can be moved later if it's used elsewhere

Yeah mind moving it to schemas? Also maybe we could PR the field into the module? They accepted my orderedItems one

i'm looking into doing the PR but I can't find the spec that defines keypair in APActor

catdevnull · 2024-03-14T17:11:17Z

src/server/announcements.ts

+      object: {
+        '@context': 'https://www.w3.org/ns/activitystreams',
+        type: 'Note',
+        id: `${this.outboxUrl}/${nanoid()}/note`,


I know nothing about json-ld 🤷 but sounds good to me

catdevnull

looks good!

catdevnull force-pushed the announcements branch from b940323 to d0507f8 Compare February 22, 2024 12:41

RangerMauve reviewed Feb 23, 2024

View reviewed changes

catdevnull requested a review from RangerMauve February 23, 2024 21:11

RangerMauve mentioned this pull request Feb 27, 2024

ID for Inbox is incomplete #46

Closed

RangerMauve requested changes Feb 28, 2024

View reviewed changes

catdevnull requested a review from RangerMauve February 29, 2024 18:25

RangerMauve requested changes Mar 5, 2024

View reviewed changes

src/server/api/announcements.ts Outdated Show resolved Hide resolved

catdevnull requested a review from RangerMauve March 6, 2024 01:33

catdevnull marked this pull request as ready for review March 7, 2024 20:24

RangerMauve requested changes Mar 8, 2024

View reviewed changes

src/server/announcements.ts Outdated Show resolved Hide resolved

src/server/announcements.ts Outdated Show resolved Hide resolved

catdevnull and others added 20 commits March 8, 2024 16:45

wip: setup announcement actor, add endpoint for actor

5320e9f

WIP: announcements post script

5f04cc2

this will probably be removed later

WIP

3d25d1a

chore(vscode): always use ts-standard

58db44c

announcements: add endpoints for outbox

5687b42

chore: add-post-to-announcements

0051dea

chore: clean up

1deddd8

feat: announce on creation

7ed3030

fix: correct http-signed-fetch types and related changes

58600ad

fix(client): remove trailing slash to setInfo endpoint

165557d

fix: only announce if doesn't exist already

f9406ed

chore: add basic client CLI

3e41d81

fix: try to get announcements inbox working

1abce31

because announcements is a separate ActorStore outside the actorCache, we bypass the actorCache when trying to act on the announcements actor. this should make the generic `/:actor/inbox` endpoint work for announcements.. but not tested

fix: missing publicKeyId

261d120

Update src/server/api/announcements.ts

18db375

Co-authored-by: Mauve Signweaver <[email protected]>

chore: remove TODO comment

e8eb6c7

mauve said it's fine it's from Mastodon

fix: sort announcements outbox by latest first

c646585

fix: move announcements stuff to APSystem subclass, fix stuff

fbb6006

* announce to announcements actor, not to newly created actor * only update required parts of announcements actor info

chore: fix linting errors

246a1b5

fix: remove trailing slash everywhere

31e9b2d

RangerMauve requested changes Mar 13, 2024

View reviewed changes

src/server/api/creation.ts Outdated Show resolved Hide resolved

RangerMauve requested changes Mar 13, 2024

View reviewed changes

src/server/announcements.ts Outdated Show resolved Hide resolved

RangerMauve requested changes Mar 13, 2024

View reviewed changes

catdevnull added 3 commits March 13, 2024 15:11

fix: try announcing new actor before creating it

0676758

otherwise .announce will never announce as it will exist beforehand

fix: use actual DB to check if actor exists already

a82ff74

fix: use announcements actor id for activity

c5c2516

catdevnull requested a review from RangerMauve March 13, 2024 18:18

fix: make tests pass

b4184a3

the same bug fixed in 0676758 applied to the test :)

RangerMauve requested changes Mar 13, 2024

View reviewed changes

src/server/announcements.ts Outdated Show resolved Hide resolved

src/server/api/creation.ts Show resolved Hide resolved

catdevnull added 2 commits March 13, 2024 17:18

fix: prevent race condition and correctly attribute announcement acti…

613d0d1

…vity

fix: wrap announcement Note in a Create

fa1cd98

catdevnull requested a review from RangerMauve March 13, 2024 20:21

fix: unused

5b4e28e

RangerMauve reviewed Mar 13, 2024

View reviewed changes

RangerMauve added 6 commits March 13, 2024 16:37

Fix ts error in announcement test

fdf3706

Implement ActorStore.delete()

debdd54

Store note separate, use mention syntax to tag new account

056279e

Fix linting, move actor definition into announcements

87de7aa

Fix linting, move actor definition into announcements

e0cfec2

progress on fixing announcement tests

1e22903

catdevnull commented Mar 14, 2024

View reviewed changes

catdevnull and others added 7 commits March 15, 2024 10:58

chore: move APActorNonStandard into schemas.ts

9816374

fix: do not include Notes in outbox

600f074

fix announcements tests

fb1fb77

Formalize auto-accepting follow requests

13a632b

Better ts lint friendly auto approve check

2f97d57

Better ts lint friendly announce check

a61a483

Better ts lint friendly announce check

8a5af82

RangerMauve merged commit f61a318 into main Mar 20, 2024
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

setup announcement actor, add endpoint for actor #42

setup announcement actor, add endpoint for actor #42

catdevnull commented Feb 13, 2024 •

edited

Loading

RangerMauve left a comment

RangerMauve left a comment

RangerMauve left a comment

RangerMauve left a comment

RangerMauve Mar 13, 2024

catdevnull Mar 13, 2024

RangerMauve Mar 13, 2024

catdevnull Mar 13, 2024

RangerMauve Mar 13, 2024

RangerMauve Mar 13, 2024

catdevnull Mar 14, 2024

catdevnull Mar 14, 2024

RangerMauve Mar 14, 2024

catdevnull Mar 15, 2024

catdevnull Mar 14, 2024

catdevnull left a comment

setup announcement actor, add endpoint for actor #42

setup announcement actor, add endpoint for actor #42

Conversation

catdevnull commented Feb 13, 2024 • edited Loading

RangerMauve left a comment

Choose a reason for hiding this comment

RangerMauve left a comment

Choose a reason for hiding this comment

RangerMauve left a comment

Choose a reason for hiding this comment

RangerMauve left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

catdevnull left a comment

Choose a reason for hiding this comment

catdevnull commented Feb 13, 2024 •

edited

Loading