-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TypeScript #80
base: main
Are you sure you want to change the base?
Fix TypeScript #80
Conversation
Use tsimp instead of ts-node and make sure all imports follow actual ESM
Marked as draft as I can't get that IPFS type error fixed. I believe it's a bug in the upstream libraries. |
Maybe you could override the types somehow? Does the code run if you ignore type errors? |
Type errors can't be ignored with tsimp, as it uses the official TypeScript compiler (tsc). That's why I suggested using something like tsx, which uses I'll try to override the types. |
I'm trying to work on this but dist.ipfs.tech is down since yesterday, so |
this causes types error and also is already done by every controller in ipfsd-ctl
sadly it seems the types in this package are bad, and we're using an outdated version. I tried upgrading the packge but it seems that there's a ton of API changes, so I'll leave it like this for now.
I think these changes are OK for now. Either way we should upgrade the |
Just noticed that while the TS is fine, the linting on the IPFS file is broken. As I mentioned we should probably migrate off of ipfsd-ctl as its types are broken and the readme says
|
Use tsimp instead of ts-node and make sure all imports follow actual ESM
Similar to hyphacoop/social.distributed.press#65