Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: external url injection problem #888

Merged

Conversation

Xsy41
Copy link
Collaborator

@Xsy41 Xsy41 commented Oct 17, 2024

Brief Information

This pull request is in the type of (more info about types):

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • test

Related issues (all available keywords):

Details

Convert openDiggerLogo and osGraphLogo to Base64 encoding.

image image

Checklist

Others

@wangyantong2000
Copy link
Collaborator

wangyantong2000 commented Oct 17, 2024

image

There are still three osgraph icons here.

@tyn1998
Copy link
Member

tyn1998 commented Oct 18, 2024

FYI, there is another way to use local assets directly to avoid the introduce of base64 images :) Maybe have a try

image

@Xsy41 Xsy41 force-pushed the fix/external-url-injection-problem branch from d0fadda to 30c9088 Compare October 18, 2024 05:34
@frank-zsy
Copy link
Contributor

If we can directly pack the image into the extension and use them in local env, that should be better than base64 encoding. Because usually base64 encoding will be a little bit larger than image format.

@Xsy41
Copy link
Collaborator Author

Xsy41 commented Oct 18, 2024

FYI, there is another way to use local assets directly to avoid the introduce of base64 images :) Maybe have a try

image

I will follow this approach and directly pack the images into the extension. This will ensure better performance and avoid the overhead of using base64 encoding.

@wangyantong2000
Copy link
Collaborator

截屏2024-10-18 20 41 55

Finally, it is necessary to align the style with the original GitHub style. At present, when on the same line, it will be slightly higher than the original label.

@Xsy41
Copy link
Collaborator Author

Xsy41 commented Oct 18, 2024

Yes, this is the revised picture.

image

@wangyantong2000 wangyantong2000 merged commit 5c5047d into hypertrons:master Oct 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] External URL injection issues, such as side label icon
4 participants