Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added functionality to retrieve and save GitHub token (#812) #837

Closed
wants to merge 1 commit into from
Closed

feat: Added functionality to retrieve and save GitHub token (#812) #837

wants to merge 1 commit into from

Conversation

wblxxx
Copy link
Contributor

@wblxxx wblxxx commented Jul 20, 2024

Brief Information

This pull request is in the type of (more info about types):

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • test

Related issues (GitHub tokens):

Details

Recently, there has been a #773 (comment) in the community about GitHub Tokens. In fact, HyperCRX had previously introduced GitHub Tokens to increase the number of requests made to GitHub, as seen in #100. However, in #574, we removed it since there was no longer a frequent need to access the GitHub API.

Considering that HyperCRX may need to frequently access the GitHub API in the future, we need to reintroduce GitHub Tokens with the following specific requirements:

Provide a UI interface allowing users to input their GitHub Tokens.
Securely store user's Tokens.
Encapsulate a network request method that uses the GitHub Token, which will be called by other new features needing to access the GitHub API in the future.

Checklist

Others

@CLAassistant
Copy link

CLAassistant commented Jul 20, 2024

CLA assistant check
All committers have signed the CLA.

@wblxxx wblxxx changed the title feat: Added functionality to retrieve and save GitHub token (#814) feat: Added functionality to retrieve and save GitHub token (#812) Jul 20, 2024
@wxharry
Copy link
Collaborator

wxharry commented Jul 20, 2024

Thanks for your contributions. Your branch has a lot of unrelated changes, please following the contribution guides to sync up and fix it.

@wxharry wxharry marked this pull request as draft July 20, 2024 14:19
@wblxxx wblxxx closed this Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants