Solsig indexed #75
Merged
Solsig indexed #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Broadhurst <[email protected]>
EnriqueL8
reviewed
Aug 27, 2024
pkg/abi/typecomponents.go
Outdated
| @@ -66,7 +66,7 @@ type TypeComponent interface { | |||
| DecodeABIData(d []byte, offset int) (*ComponentValue, error) | |||
| DecodeABIDataCtx(ctx context.Context, d []byte, offest int) (*ComponentValue, error) | |||
|
|
|||
| SolidityParamDef(inFunction bool) (solDef string, structDefs []string) // gives a string that can be used to define this param in solidity | |||
| SolidityParamDef(isFunction, isEvent bool) (solDef string, structDefs []string) // gives a string that can be used to define this param in solidity | |||
There was a problem hiding this comment.
From what I understand they are mutuality exclusive, feels like this should be an enum as it's either one or the other
There was a problem hiding this comment.
ok - moving interface to enum and refactoring
| if isRef && inFunction { | ||
| paramDef = fmt.Sprintf("%s memory", paramDef) | ||
| if isRef && isFunction { | ||
| paramDef += " memory" |
There was a problem hiding this comment.
why the change from sprintF to +=?
There was a problem hiding this comment.
just felt more readable
Signed-off-by: Peter Broadhurst <[email protected]>
EnriqueL8
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Thank for making those changes @peterbroadhurst , looks a lot nearer to me now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After all the work in #71, I ended up missing one of the most important distinguishing things the feature was meant to help with 🤦
The ABI signature of an event is identical for ERC-20/ERC-721, but some of the fields are indexed. I'd missed including that.
In PR chain with #73