Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC 0809 - VCDI Credential offer request alternate proposal #828

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

PatStLouis
Copy link

I'd like to suggest a re-alignment with the vc-api approach for the credential offer attachment. I'm not convinced the suggested change provides sufficient improvements and the rational aligns with the direction of the vc-api. The Credential Offer Exceptions section is in line with the recent discussions on the vc-api calls.

This change seems to get rid of a dedicated options field and put all options at the root layer of the request.

The JSON-LD attachment dates from 2021 and the vc-api specification has changed since then.

I have a few questions:

  • Why include the data model version in the options? Could it not be derived from the context? In which scenario would an array be beneficial?
  • Why include a binding_required bool? Could it not be assumed as required if there is a binding_method present? Is there a scenario where the binding isn't required but a method is provided?

@TimoGlastra

Signed-off-by: Patrick St-Louis <[email protected]>
Signed-off-by: Patrick St-Louis <[email protected]>
@PatStLouis PatStLouis changed the title Credential offer proposal RFC 0809 - VCDI Credential offer request alternate proposal Apr 22, 2024
@TelegramSam
Copy link
Contributor

Discussed 2024. Hard to merge given the changes, but could be useful in a note on the RFC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants