Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support build on XCode 14 #49

Merged
merged 1 commit into from
May 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions AriesFramework/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,17 @@ end
target 'AriesFrameworkTests' do
pod 'Criollo', '~> 0.5'
end

post_install do |installer|
desired_ios = '15.0'

installer.pods_project.targets.each do |target|
target.build_configurations.each do |config|
settings = config.build_settings
actual = Gem::Version.new(settings['IPHONEOS_DEPLOYMENT_TARGET'])
if actual < desired_ios
settings['IPHONEOS_DEPLOYMENT_TARGET'] = desired_ios
end
end
end
end
2 changes: 1 addition & 1 deletion AriesFramework/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,6 @@ SPEC CHECKSUMS:
OpenSSL-Universal: ff34003318d5e1163e9529b08470708e389ffcdd
WebSockets: 32c0aba46c23d11ad175c8da46e3f34657b17535

PODFILE CHECKSUM: 868f1e063849308d0169b425566ee3e3b9cc82d3
PODFILE CHECKSUM: 130b1d28fa3126d17cf60f165f8ab3fd6e812988

COCOAPODS: 1.12.0
13 changes: 13 additions & 0 deletions DEVELOP.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,18 @@
# Framework Development Guide

## CI related

### Linting
We are using GitHub Actions for Lint check. See .github/workflows for details.
Run swiftlint at the root of the repo to check linting locally.

### CocoaPods version
We need to use CocoaPods 1.12.0 to be compatible with GitHub Actions macOS runner.
```
brew uninstall cocoapods
sudo gem install cocoapods -v 1.12.0
```

## Depencencies

### Indy SDK
Expand Down
21 changes: 19 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,24 @@ source 'https://github.com/naver/indy-sdk.git'

And add a pod depencency to the Podfile:
```
pod 'AriesFramework'
pod 'AriesFramework', '~> 1.2'
```

Also add the following post install script to the Podfile:
```ruby
post_install do |installer|
desired_ios = '15.0'

installer.pods_project.targets.each do |target|
target.build_configurations.each do |config|
settings = config.build_settings
actual = Gem::Version.new(settings['IPHONEOS_DEPLOYMENT_TARGET'])
if actual < desired_ios
settings['IPHONEOS_DEPLOYMENT_TARGET'] = desired_ios
end
end
end
end
```

You need cocoapods and cmake to install the dependencies to your app.
Expand All @@ -41,7 +58,7 @@ $ brew install cocoapods cmake
```

Then run `pod install` to install the dependencies.
Building on Apple silicon Mac is not supported yet.
Building on Apple silicon Mac for iOS simulator is not supported yet.

## Usage

Expand Down
14 changes: 14 additions & 0 deletions Sample/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,17 @@ target 'wallet-app-ios' do

pod 'AriesFramework', '~> 1.2'
end

post_install do |installer|
desired_ios = '15.0'

installer.pods_project.targets.each do |target|
target.build_configurations.each do |config|
settings = config.build_settings
actual = Gem::Version.new(settings['IPHONEOS_DEPLOYMENT_TARGET'])
if actual < desired_ios
settings['IPHONEOS_DEPLOYMENT_TARGET'] = desired_ios
end
end
end
end
4 changes: 2 additions & 2 deletions Sample/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,6 @@ SPEC CHECKSUMS:
OpenSSL-Universal: ff34003318d5e1163e9529b08470708e389ffcdd
WebSockets: 32c0aba46c23d11ad175c8da46e3f34657b17535

PODFILE CHECKSUM: b355fe1d5258d6932109e2ad1320abb86a558af2
PODFILE CHECKSUM: 6ed769b0ae6437fbb0960288a5ac2b5ecd6d2e47

COCOAPODS: 1.11.3
COCOAPODS: 1.12.0