refactor: streamline GenesisBuilder
RawGenesisTransaction
GenesisBlock
flow
#5191
+264
−235
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
iroha_genesis
there is room to reduce some functions and their argumentsGenesisBuilder
andRawGenesisTransaction
can e.g.append_instruction
Solution
GenesisBuilder
RawGenesisTransaction
GenesisBlock
flowGenesisBuilder
andRawGenesisTransaction
GenesisBuilder
has building methods likeappend_instruction
RawGenesisTransaction
to revertinto_builder
to rebuildChecklist
CONTRIBUTING.md
.