Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: streamline GenesisBuilder RawGenesisTransaction GenesisBlock flow #5191

Merged
merged 1 commit into from
Oct 25, 2024
Merged

refactor: streamline GenesisBuilder RawGenesisTransaction GenesisBlock flow #5191

merged 1 commit into from
Oct 25, 2024
+264 −235

Conversation

s8sato
Copy link
Contributor

@s8sato s8sato commented Oct 24, 2024

Context

  • in iroha_genesis there is room to reduce some functions and their arguments
  • currently both GenesisBuilder and RawGenesisTransaction can e.g. append_instruction

Solution

  • streamline GenesisBuilder RawGenesisTransaction GenesisBlock flow
  • clarify the responsibility boundary between GenesisBuilder and RawGenesisTransaction
    • only GenesisBuilder has building methods like append_instruction
    • allow RawGenesisTransaction to revert into_builder to rebuild

Checklist

  • I've read CONTRIBUTING.md.
  • All review comments have been resolved.
  • All CI checks pass.

@s8sato s8sato self-assigned this Oct 24, 2024
@s8sato s8sato marked this pull request as ready for review October 24, 2024 03:36
@s8sato s8sato enabled auto-merge (squash) October 24, 2024 05:33
s8sato
s8sato commented Oct 24, 2024
View reviewed changes
crates/iroha_data_model/src/parameter.rs Outdated Show resolved Hide resolved
crates/iroha_genesis/src/lib.rs Show resolved Hide resolved
crates/iroha_genesis/src/lib.rs Show resolved Hide resolved
crates/iroha_genesis/src/lib.rs Show resolved Hide resolved
mversic
mversic previously approved these changes Oct 24, 2024
View reviewed changes
@s8sato s8sato merged commit aa4d60b into hyperledger-iroha:main Oct 25, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x009922 0x009922 0x009922 approved these changes

@mversic mversic mversic approved these changes

@SamHSmith SamHSmith Awaiting requested review from SamHSmith SamHSmith is a code owner

@outoftardis outoftardis Awaiting requested review from outoftardis

@DCNick3 DCNick3 Awaiting requested review from DCNick3

@dima74 dima74 Awaiting requested review from dima74 dima74 is a code owner

Assignees

@s8sato s8sato

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@s8sato @0x009922 @mversic