Implement part of #1557: Add tests for replayRate controller. #1579
Conversation
Signed-off-by: rahat2134 <[email protected]>
|
@davidkel PTAL. |
| afterEach(() => { | ||
| sandbox.restore(); | ||
| }); | ||
|
|
There was a problem hiding this comment.
we need to describe what was being done here as well, so we need a describe wrapping the first 3 it statements with a description such as
When creating the replay rate controller
| fs.unlinkSync(tempFilePath); | ||
| }); | ||
|
|
||
| it('should correctly apply rate control and log warning when running out of transaction timings', async () => { |
There was a problem hiding this comment.
There are 2 different tests here, can we split them into 2 please. One where there are no log warnings and one where there are log warnings
| fs.unlinkSync(tempFilePath); | ||
| }); | ||
|
|
||
| it('should call end() method without any errors', async () => { |
There was a problem hiding this comment.
We try to avoid method names in descriptions of tests and focus on behaviour descriptions. It's a way to understand what this test is trying to achieve. Then it also helps to understand what behaviours may also be missing in the tests. So for this one it is testing that the rate controller is never actually used, but what about when it is used ? We don't want be influenced by the implementation as it then keeps the tests viable for when changes are made to the implementation.
Proof
Checklist
Issue/User story
Add tests for replayRate controller.