Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve JSON data from an external source #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

humitos
Copy link
Owner

@humitos humitos commented Oct 26, 2018

Allow the user to define a custom URL to retrieve the JSON data (instead of hitting Read the Docs API) needed to add the banner into the page.

This is useful when there is a git tag that doesn't want to be updated, but now the warning message is out of date. So, by defining a custom URL (potentially a JSON under the git repository served by github, for example) this file is retrieved by the documentation and displayed the custom message needed at certain date.

The JSON file can be updated independently from the documentation/tag/etc.

Initial implementation of #14

@humitos humitos force-pushed the dynamic-data-from-url branch 3 times, most recently from 968c43e to 0c17a31 Compare October 26, 2018 13:50
Allow the user to define a custom URL to retrieve the JSON
data (instead of hitting Read the Docs API) needed to add the banner
into the page.

This is useful when there is a git tag that doesn't want to be
updated, but now the warning message is out of date. So, by defining a
custom URL (potentially a JSON under the git repository served by
github, for example) this file is retrieved by the documentation and
displayed the custom message needed at certain date.

The JSON file can be updated independently from the documentation/tag/etc.
@humitos
Copy link
Owner Author

humitos commented Oct 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant