Adding ONNX support for ImageGPT #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adit299
changed the title
…_ONNX_Support_for_ImageGPT_Model
|
Hello, I believe I have completed adding ONNX support for ImageGPT. I ran the tests mentioned here (but using imagegpt instead of resnet) and they pass:
Please do let me know if everything is good with this PR! |
…_ONNX_Support_for_ImageGPT_Model
|
The documentation is not available anymore as the PR was closed or merged. |
regisss
reviewed
Mar 3, 2023
| if self._behavior is ConfigBehavior.DECODER: | ||
| common_inputs["encoder_outputs"] = {0: "batch_size", 1: "encoder_sequence_length"} | ||
|
|
||
There was a problem hiding this comment.
The code quality test didn't pass. Can you run the command make style in the root of the Optimum repo (you'll need to have the right packages installed with pip install -e .[dev,exporters])?
| @@ -59,6 +59,7 @@ | |||
| "gptj": "hf-internal-testing/tiny-random-GPTJModel", | |||
| "groupvit": "hf-internal-testing/tiny-random-groupvit", | |||
| "ibert": "hf-internal-testing/tiny-random-IBertModel", | |||
| "imagegpt": "hf-internal-testing/tiny-random-ImageGPTModel", | |||
There was a problem hiding this comment.
Could you also add an entry below in PYTORCH_EXPORT_MODELS_LARGE for this model for instance?
fxmarty
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #555
Before submitting