Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gpt-neo-x support #745

Merged
merged 3 commits into from
Feb 7, 2023
Merged

Add gpt-neo-x support #745

merged 3 commits into from
Feb 7, 2023

Conversation

sidthekidder
Copy link
Contributor

What does this PR do?

Support GPT-Neo-X model config.

Fixes #555

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@sidthekidder
Copy link
Contributor Author

Hi @fxmarty, I'm trying to add support for GPT-Neo-X model (similar to the existing GPT-Neo model). Though I'm not sure what's the best way to test this locally?

fxmarty
fxmarty reviewed Feb 6, 2023
View reviewed changes
Copy link
Contributor

@fxmarty fxmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for your contribution! Left a few comments.

optimum/exporters/onnx/model_configs.py Outdated Show resolved Hide resolved
optimum/exporters/tasks.py Outdated Show resolved Hide resolved
optimum/exporters/tasks.py Show resolved Hide resolved
optimum/utils/normalized_config.py Outdated Show resolved Hide resolved
tests/onnxruntime/test_modeling.py Outdated Show resolved Hide resolved
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Feb 6, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@sidthekidder sidthekidder changed the title [WIP] Add gpt-neo-x support Add gpt-neo-x support Feb 7, 2023
fxmarty
fxmarty approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@fxmarty fxmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is all good, thank you for the addition!

@fxmarty fxmarty merged commit f02f227 into huggingface:main Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fxmarty fxmarty fxmarty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Community contribution - optimum.exporters.onnx support for new models!
3 participants
@sidthekidder @HuggingFaceDocBuilderDev @fxmarty