Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mccalluc/consistent names #71

Open
wants to merge 2 commits into
base: mccalluc/consistent-arrays
Choose a base branch
from

Conversation

mccalluc
Copy link
Contributor

The PR that this is based on goes a long way to make the code more consistent -- This continues that by cleaning up the names. Currently there are a mixture of conf, config, viewconf and vc. This establishes config as the consistent name in the code, and view config in the docs. The couple of places where we're dealing with a dictionary rather than an object are now explicit: config_as_dict.

In main there are 90 matches for confs?(\b|_): Here there are none. Similarly, 97 vcs have been cleaned up.

I have not gone as far as changing the class names (ViewConfBuilder) ... Those are internally consistent, and exposed externally, so there's more risk of disruption in changing them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants