Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update portal-ui maintenance for Dec 2023 outage. #300

Merged
merged 1 commit into from
Dec 16, 2023

Conversation

lchoy
Copy link
Contributor

@lchoy lchoy commented Dec 14, 2023

Updates portal UI messaging for Dec 19-20, 2023 planned outage.

@lchoy lchoy requested a review from yuanzhou December 14, 2023 23:07
Copy link
Member

@yuanzhou yuanzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lchoy looks like the main update is to show

Portal is unavailable for scheduled maintenance from December 19th to December 20th, 2023.

Is this configurable or just hardcoded for one-time use? Maybe I can just update the minified file with this message without doing anything to this PR?

<!doctype html><html><head><meta charset="utf-8"/><meta name="viewport" content="width=device-width,initial-scale=1,shrink-to-fit=no"/><title>Maintenance | HuBMAP</title><script>const sentryEnv = '{{ sentry_env }}';</script><link rel="icon" href="favicon.ico"><script defer="defer" src="maintenance.bundle.js"></script></head><body><div id="react-content"></div></body></html>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this sentry_env? Do I need to do anything specially?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sentry_env is a variable for Portal tracking. There's nothing that needs to be done for that.

This PR is an updated hardcoded message for one-time use. We'll address making the messaging configurable in a later update.

Copy link
Member

@yuanzhou yuanzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lchoy I'm gonna merge this PR and use the updated maintenance info for the 19-20 PSC outage.

After this one-time use, we'll need to either change the message (only the message wording) back to a generic sentence or make it configurable for later use.

@yuanzhou yuanzhou merged commit a8be549 into main Dec 16, 2023
2 checks passed
@yuanzhou yuanzhou deleted the lchoy/update-portal-maintenance-message-dec2023 branch December 16, 2023 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants