Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auto_source): add support for auto_source feature #676

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

gildesmarais
Copy link
Member

@gildesmarais gildesmarais commented Aug 17, 2024

Depends on html2rss/html2rss#202 || v0.14.0

This pull request

  1. enables the use of auto_source
  2. The feature is disabled by default and
  3. uses https://github.com/arkadiyt/ssrf_filter to protect against SSRF attack.

Further changes include adding required gems, updating documentation, refactoring the codebase.

New Features:

  • Added new gems base64 and ssrf_filter to the Gemfile for improved security and functionality. (Gemfile, GemfileR14-R21)
  • Introduced the automatic feed generation feature with detailed instructions in the README.md. (README.md, README.mdR69-R93)

Documentation Updates:

  • Updated the README.md to include instructions for enabling the auto_source feature and added new environment variables to the supported list. (README.md, README.mdL116-L123)

Code Refactoring:

  • Refactored the app.rb file to improve readability and maintainability by removing redundant methods and adding constants. (app.rb, [1] [2] [3] [4]
  • Moved Rack::Timeout middleware setup to the production environment in config.ru. (config.ru, [1] [2]

Error Handling:

  • Enhanced error handling in helpers/handle_error.rb by adding a specific case for Html2rss::Error and refactoring the method to improve clarity. (helpers/handle_error.rb, helpers/handle_error.rbR18-R32)

Frontend Improvements:

  • Added new CSS and JavaScript files to support the auto-source feature, enhancing the user interface and experience. (public/auto_source.css, [1]; public/auto_source.js, [2]

@gildesmarais gildesmarais changed the title development env checks feat: enable use of auto_source Aug 17, 2024
@gildesmarais gildesmarais force-pushed the feat/auto-source-integration branch 3 times, most recently from 13c5037 to 920463e Compare August 20, 2024 14:25
@gildesmarais gildesmarais force-pushed the feat/auto-source-integration branch 2 times, most recently from 86707f1 to d04dfb3 Compare October 8, 2024 09:59
@gildesmarais gildesmarais changed the title feat: enable use of auto_source feat(auto_source): add support for auto_source feature Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

1 participant