-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for string:binary. + more. #11
base: master
Are you sure you want to change the base?
Conversation
+ formatting
…ovider: ```dart abstract class ApiEndpointWithRequest { OpenApiRequest? request; } class TestApiImpl extends TestApi implements ApiEndpointWithRequest { @OverRide OpenApiRequest? request; ShelfRequest get shelfRequest => request! as ShelfRequest; //... } /// Endpoint provider with Request. class OpenapiEndpointProvider<ENDPOINT extends TestApiImpl> extends ApiEndpointProvider<ENDPOINT> { /// Constructor OpenapiEndpointProvider(this.implementation); /// Implementation final ENDPOINT implementation; @OverRide Future<RET> invoke<RET>( OpenApiRequest request, ApiEndpointCallback<ENDPOINT, RET> callback, ) async { implementation.request = request; return await callback(implementation); } } ``` + formatting
+ formatting + assignFinal -> declareFinal
somehow this PR has quite a few formatting changes.. are you using |
ok. Now it is formatted using 'dart format'. (flutter ) $ dart --version
Dart SDK version: 2.19.6 (stable) (Tue Mar 28 13:41:04 2023 +0000) on "windows_x64"
$ dart format .
Formatted packages\openapi_base\lib\src\openapi_base.dart
Formatted packages\openapi_base\lib\src\openapi_exception.dart
Formatted packages\openapi_base\lib\src\server\openapi_shelf_server.dart
Formatted packages\openapi_code_builder\example\bin\example_server.dart
Formatted packages\openapi_code_builder\lib\openapi_code_builder.dart
Formatted packages\openapi_code_builder\lib\src\openapi_code_builder.dart
Formatted 26 files (6 changed) in 0.58 seconds. |
# Conflicts: # packages/openapi_base/CHANGELOG.md # packages/openapi_base/pubspec.lock # packages/openapi_base/pubspec.yaml # packages/openapi_code_builder/example/pubspec.lock # packages/openapi_code_builder/pubspec.lock # packages/openapi_generator_flutter/pubspec.lock # packages/openapi_generator_flutter/pubspec.yaml
# Conflicts: # packages/openapi_base/CHANGELOG.md # packages/openapi_base/lib/src/util/uuid.dart # packages/openapi_base/pubspec.yaml # packages/openapi_code_builder/CHANGELOG.md # packages/openapi_code_builder/example/pubspec.lock # packages/openapi_code_builder/example/pubspec.yaml # packages/openapi_code_builder/pubspec.yaml
Would it. be possible to split the PR up into just adding binary support?
which doesn't use thanks |
Hello, thank you for attention. I unforced dependencies right now, so there are almost no
Passes tests and runs without any problems. I have no plans to split PR, just because I completely satisfied with it.
|
Description
ShelfRequest.request
for using in handler implementations. Especially forshelf.Request.context
interchanging between middlewares and handlers. For providing auth credentials from auth middleware to handlers for example.