Support for string:binary. + more. #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ formatting
…ovider:
```dart
abstract class ApiEndpointWithRequest {
OpenApiRequest? request;
}
class TestApiImpl extends TestApi implements ApiEndpointWithRequest {
@OverRide
OpenApiRequest? request;
ShelfRequest get shelfRequest => request! as ShelfRequest;
//...
}
/// Endpoint provider with Request.
class OpenapiEndpointProvider<ENDPOINT extends TestApiImpl>
extends ApiEndpointProvider<ENDPOINT> {
/// Constructor
OpenapiEndpointProvider(this.implementation);
/// Implementation
final ENDPOINT implementation;
@OverRide
Future<RET> invoke<RET>(
OpenApiRequest request,
ApiEndpointCallback<ENDPOINT, RET> callback,
) async {
implementation.request = request;
return await callback(implementation);
}
}
```
+ formatting
+ formatting + assignFinal -> declareFinal
|
somehow this PR has quite a few formatting changes.. are you using |
|
ok. Now it is formatted using 'dart format'. (flutter ) $ dart --version
Dart SDK version: 2.19.6 (stable) (Tue Mar 28 13:41:04 2023 +0000) on "windows_x64"
$ dart format .
Formatted packages\openapi_base\lib\src\openapi_base.dart
Formatted packages\openapi_base\lib\src\openapi_exception.dart
Formatted packages\openapi_base\lib\src\server\openapi_shelf_server.dart
Formatted packages\openapi_code_builder\example\bin\example_server.dart
Formatted packages\openapi_code_builder\lib\openapi_code_builder.dart
Formatted packages\openapi_code_builder\lib\src\openapi_code_builder.dart
Formatted 26 files (6 changed) in 0.58 seconds. |
# Conflicts: # packages/openapi_base/CHANGELOG.md # packages/openapi_base/pubspec.lock # packages/openapi_base/pubspec.yaml # packages/openapi_code_builder/example/pubspec.lock # packages/openapi_code_builder/pubspec.lock # packages/openapi_generator_flutter/pubspec.lock # packages/openapi_generator_flutter/pubspec.yaml
# Conflicts: # packages/openapi_base/CHANGELOG.md # packages/openapi_base/lib/src/util/uuid.dart # packages/openapi_base/pubspec.yaml # packages/openapi_code_builder/CHANGELOG.md # packages/openapi_code_builder/example/pubspec.lock # packages/openapi_code_builder/example/pubspec.yaml # packages/openapi_code_builder/pubspec.yaml
|
Would it. be possible to split the PR up into just adding binary support? which doesn't use thanks |
|
Hello, thank you for attention. I unforced dependencies right now, so there are almost no
Passes tests and runs without any problems. I have no plans to split PR, just because I completely satisfied with it.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ShelfRequest.requestfor using in handler implementations. Especially forshelf.Request.contextinterchanging between middlewares and handlers. For providing auth credentials from auth middleware to handlers for example.