Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#stdout coverage format #480

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

LeonMatthes
Copy link
Collaborator

Introduce the #stdout coverage format.
Prints a coverage report before the test summary.
Useful if you don't want to use a separate coverage provider or your coverage provider is not supported.

Also implements the ability to output more than one coverage format.

@LeonMatthes LeonMatthes marked this pull request as draft October 12, 2020 19:19
@LeonMatthes LeonMatthes marked this pull request as ready for review October 13, 2020 18:34
@LeonMatthes
Copy link
Collaborator Author

@fniephaus
Note that I've changed smalltalkCI's .smalltalk.ston to use all supported coverage formats, #coveralls, #lcov and #stdout, so it implicitly tests them each run.

@fniephaus
Copy link
Member

Hi @LeonMatthes,
It looks like testSentButNotImplemented is failing on GemStone. Could you please take a look?

@LeonMatthes
Copy link
Collaborator Author

Ah, it seems Gemstone is actually not loading the Coverage package, which is where the exportResultsIn:-method is implemented. It is called from SmalltalkCI>>#basicTest if coverage is available.

I'll see what I can do to fix this.

@fniephaus
Copy link
Member

Thanks!

@LeonMatthes
Copy link
Collaborator Author

@fniephaus . It seems the Merge of the master branch into this fork somehow bricked Pharo builds. Do you have any idea what might be causing this?
I suspect it might be the monticello.meta/version file. I think I just picked one of them... Can they cause issues like this?

@fniephaus
Copy link
Member

Yes, very much possible this is caused by corrupted metadata. Can you fix this by hand?

@fniephaus
Copy link
Member

Maybe try reproducing locally?

@fniephaus
Copy link
Member

There's now a GemStone build running on GitHub Actions, maybe that helps to debug the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants